On Sat, Jun 4, 2011 at 02:58, Roland Vossen <rvossen@xxxxxxxxxxxx> wrote: > On 06/02/2011 05:06 AM, Julian Calaby wrote: >> >> Roland, >> >> I've passed an eye over the entire patch set. >> >> My comments are pretty minor, but I've replied to the patches that I >> have concerns for. Please note that I'm not really a developer, and my >> comments are mostly style issues, not actual functional issues. Oh, >> and also, I read most of the patches out of order, so some of the >> comments may not make complete sense. >> >> Overall, my comments are these: >> 1. If you're doing typedef removals in a patch, mention it in the summary. >> 2. Work on your summaries, there are a few cases where I think they're >> a little too terse. >> 3. Good work! >> 4. Keep going =) > > Thanks ! Your comments are noted. Btw, this patch train is not just the > fruit of my labor, so Arend and Franky deserve this credit as well :-) Of course! I was addressing you as you posted them to the list. >> 3. Do a typedef removal sweep over the code because typedefs are ugly =) > > Agree. At the end of the patch train, all typedefs have been moved over to > one file. Next step is to get rid of them. Cool! >> 4. I had a glance at /Documentation/CodingStyle and saw that there >> were some issues mentioned in there that could be fixed in your code. >> You might also want to play with checkpatch. > > When writing new code, we adhere to checkpatch. But in these patches, a lot > of (existing) code was moved around. We could have placed a separate commit > after each move that fixed up checkpatch issues (not in the same commit > since that blocks tools from detecting the movement of code), but at the > moment the focus is on structural code cleanup (reducing number of .c and .h > files, removing dead code, etc). Fair enough, was just pointing it out. >> I'm probably missing a whole lot of other, much more important, stuff, >> but this is what I saw. > > Valuable feedback, taken into account. Thanks for investing time in this. No problem, I try to pass my eye over all patches that make their way through the list, particularly if they're for drivers I care about. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
