On Wed, Jun 1, 2011 at 21:45, Roland Vossen <rvossen@xxxxxxxxxxxx> wrote:
> From: Arend van Spriel <arend@xxxxxxxxxxxx>
>
> The file aiutils.c included the register definition includes for the
> PCI and PCIe core. This was for two functions which have been partly
> moved to nicpci.c. This means that nicpci.h is the only include file
> to provide interface to aiutils.c for PCI core related functions.
>
> Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx>
> Reviewed-by: Roland Vossen <rvossen@xxxxxxxxxxxx>
> ---
> diff --git a/drivers/staging/brcm80211/brcmsmac/aiutils.c b/drivers/staging/brcm80211/brcmsmac/aiutils.c
> index bae40fe..43320b4 100644
> --- a/drivers/staging/brcm80211/brcmsmac/aiutils.c
> +++ b/drivers/staging/brcm80211/brcmsmac/aiutils.c
> @@ -1915,7 +1913,7 @@ void ai_pci_down(si_t *sih)
> void ai_pci_setup(si_t *sih, uint coremask)
> {
> si_info_t *sii;
> - struct sbpciregs *pciregs = NULL;
> + void *regs = NULL;
> u32 siflag = 0, w;
> uint idx = 0;
>
Is changing this to void* necessarily a good idea? - the regs variable
appears to only be used by PCI code, so having it declared as a struct
sdpciregs* isn't going to make it any less generic - and having it
declared as a structure would help to spot bugs in the code.
Thanks,
--
Julian Calaby
Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
