On Mon, May 23, 2011 at 01:43:13PM -0700, Linus Torvalds wrote: > On Mon, May 23, 2011 at 12:38 PM, Greg KH <greg@xxxxxxxxx> wrote: > > Here is the big pull request for the staging tree for your .40 tree (or > > 2.8.0, whatever you are wanting to rename it to.) > > Hmm. Doing my once-a-release "try to compile everything in staging > after pulling from greg by using allyesconfig and also forcing all > staging", Ugh, I keep only testing 'allmodconfig' with all staging drivers, I'll add this to my test build setup from now on. > I get this: > > drivers/staging/brcm80211/brcmsmac/built-in.o:(.data+0xba0): > multiple definition of `wl_msg_level' > drivers/staging/brcm80211/brcmfmac/built-in.o:(.data+0x1a94): first > defined here > > which looks like another case of "can't compile two things both into > the kernel". > > Looks like the BRCMSMAC / BRCMFMAC drivers need to be mutually > exclusive. Something like > > depends on m || (BRCMSMAC != y) > > for BRCMFMAC? > > Or they should just avoid using the same globally visible name. Both probably. I'll fix this up for the next set of staging fixes after you release -rc1. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
