> -----Original Message----- > From: Greg KH [mailto:greg@xxxxxxxxx] > Sent: Tuesday, May 17, 2011 2:46 PM > To: KY Srinivasan > Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; Haiyang Zhang; Abhishek > Kane (Mindtree Consulting PVT LTD); Hank Janssen > Subject: Re: [PATCH 14/64] Staging: hv: Include asm/hyperv.h in hyperv.h > > On Thu, May 12, 2011 at 07:34:27PM -0700, K. Y. Srinivasan wrote: > > Include asm/hyperv.h in hyperv.h. > > Huh? There is no "asm/hyperv.h" file. Why do you say there is no asm/hyperv.h; look under arch/x86/include/asm. This file was introduced a while ago and already had many definitions that we had in one of our local files (hv_api.h). So in the spirit of getting rid of duplicate definitions, I included an existing file (asm/hyperv.h). So, I had get rid of duplicate definitions in our local file. > > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > Signed-off-by: Abhishek Kane <v-abkane@xxxxxxxxxxxxx> > > Signed-off-by: Hank Janssen <hjanssen@xxxxxxxxxxxxx> > > --- > > drivers/staging/hv/hv_api.h | 514 ------------------------------------------- > > drivers/staging/hv/hyperv.h | 21 +- > > 2 files changed, 10 insertions(+), 525 deletions(-) > > You just deleted a bunch of things here that hopefully were not being > used, are you sure you wanted to do that? > > If so, that doesn't match up with what the Subject: says is going on > here :( As I noted earlier, what I deleted were things that already were defined in asm/hyperv.h and this had to be done concurrently with including asm/hyperv.h. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
