Re: [PATCH] brcm80211: Allow scans after scanning for specific ssid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 11, 2011 at 11:28 PM, Sukesh Srikakula <sukeshs@xxxxxxxxxxxx> wrote:
> Hi Sean,
>
> Your fix looks to be hacky.

Hi Sukesh,
This is a case of "the pot calling the kettle black".  This whole
driver is hacky.

While Sean's patch might be hacky, it fixes the functional problem
with the driver that he's experiencing.  This is worth more to me than
unpublished patches that are "under review".

> With your fix, brcm driver will always report success for cfg80211_scan_done. But, there are some occasions where scan may be aborted by FW, which needs to be reported to cfg80211.
>
> In my view, first we need to debug why iscan is unable to send cfg80211_scan_done notification.

What information do you need to debug this?
I'm sure Sean can provide that information.

>Recently, we fixed some issues related to scan. Those fixes might help here.
> Currently they are under review. Will let you know once they reached the staging tree.

Can you please send Sean Paul patches to test if you aren't willing to
publish them today?
Take advantage of the opportunity to collaborate. :)

You'll then be able to add a "tested-by:" line from someone other than
Broadcom if it works.

cheers,
grant
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux