> -----Original Message----- > From: Greg KH [mailto:greg@xxxxxxxxx] > Sent: Wednesday, May 11, 2011 6:38 PM > To: KY Srinivasan > Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; Haiyang Zhang; Abhishek > Kane (Mindtree Consulting PVT LTD) > Subject: Re: [PATCH 152/206] Staging: hv: Create a common header for all hyperv > drivers to include > > On Wed, May 11, 2011 at 10:34:41PM +0000, KY Srinivasan wrote: > > > > > > > -----Original Message----- > > > From: Greg KH [mailto:greg@xxxxxxxxx] > > > Sent: Wednesday, May 11, 2011 4:55 PM > > > To: KY Srinivasan > > > Cc: gregkh@xxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; Haiyang Zhang; Abhishek > > > Kane (Mindtree Consulting PVT LTD) > > > Subject: Re: [PATCH 152/206] Staging: hv: Create a common header for all > hyperv > > > drivers to include > > > > > > On Tue, May 10, 2011 at 07:56:18AM -0700, K. Y. Srinivasan wrote: > > > > Create a common header (hyperv.h) for all hyperv drivers to include. > > > > Free at last ... > > > > > > Nope, not so quick, you're still chained down :) > > > > > > Here's where I stopped in applying patches, I did the first 151, which > > > was a good run... > > > > > > A few notes on when you redo the remaining patches. > > > > > > When you create the hyperv.h file, move the stuff from one .h file into > > > this one at the same time, don't do a "add the structures" in one patch, > > > and then "delete the structures from the old one" on another. By doing > > > it in one patch, git can better track things when they move to keep the > > > history sane when trying to research things in the past. > > > > Just to be sure, you want the add/delete to happen in one patch. You still > > want the addition/deletion of each header file to be in a separate patch; right? > > I was thinking of something like: > > - First patch would create hyperv.h and include it in all .c files > - Second patch would move the structures from the first .h file into > hyperv.h and delete that .h file. > - Third patch the same, and so on. > > Which would keep git, and developers, happy. That is what I had understood and before I sent these modified patches out I just wanted to make sure. Thanks, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
