On Wed, 11 May 2011 12:55 -0700, "Greg KH" <greg@xxxxxxxxx> wrote: [snip] > > I need a "Signed-off-by:" line as described in the file, > Documentation/SubmittingPatches in order to be able to accept this > patch. Will do. > > diff -Naurd linux-staging-2.6.32.8/drivers/staging/comedi/drivers/vmk80xx.c linux-staging-2.6.32.8-bis/drivers/staging/comedi/drivers/vmk80xx.c > > The 2.6.32.8 kernel is _very_ old, can you please generate this patch > against the latest development kernel instead so that we can apply it > properly? Yes, I think I can do that. I won't be able to test it, but I don't suppose that matters. Can you help a complete newbie and tell me which version the latest development kernel relates to? I see on the front page of kernel.org, linux-next, snapshot and mainline. Is it one of them, or something else? [snip] > > I don't think your changes allow you to add your copyright to the file, > based on the guidelines my lawyers have given me. Do you have different > legal advice that contridicts this? Nope, just gut feeling :) [snip] > The "updated" and "changelog" sections don't matter anymore now that the > drivers are in the main kernel tree, so you don't have to do this. Thanks. > Please run your patch through the scripts/checkpatch.pl tool and fix the > issues it finds before making us do the same thing and pestering you to > make them :) > > Could you make these changes and resend the patch so we can apply it to > the tree? Shouldn't be a problem. Thanks for your feedback. Ali. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
