Re: [PATCH 000/206] Staging: hv: Cleanup hv drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 10, 2011 at 07:56:34AM -0700, K. Y. Srinivasan wrote:
> This is a resend of the patches sent on May 9, 2011. Per Greg's
> suggestion, I have include additional context to the Subject line
> where there was some ambiguity.
> 
> This patch-set deals with some of the architectural isues in all of
> the Hyper-V drivers. Specifically:

They finally all came through now, or at least I think they all did.

Please fix your email system to not swallow them for 8+ hours in the
future, this really isn't an acceptable way of doing work.

> 	1) Fixes a number of locking issues in the block driver.
> 
> 	2) Eliminates all the indirection through the hv_driver
> 	   abstraction.
> 
> 	3) Simplifies the code across the board eliminating 
> 	   unnecessary code and data structure layering. Prior to
> 	   this restructuring there were about 11,000 lines of code
> 	   in the hv directory. After this cleanup, there are about
> 	   8500 lines of code.

That's great, remember how many lines were at the beginning?  I think it
was over 40000 or so, but I could be wrong, I should go and dig up the
original code dump from so long ago to be sure...

> 	4) I have dealt with style and naming issues across all the drivers.
> 
> 	5) All the header files have been cleaned up and consolidated:
> 		1) A single header file include/linux/hyperv.h. This file
> 		   is to be included in all the drivers that attach to the
> 		   vmbus.

Woah, no.  You can't move out of the drivers/staging/hv/ directory yet,
sorry.  I'll go through and review and try to apply these patches but
will probably stop when you do this file movement, sorry.  I'll let you
know how far I get when I do this.

thanks,

gerg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux