2011/5/8 Hauke Mehrtens <hauke@xxxxxxxxxx>: > On 05/05/2011 11:59 PM, RafaÅ MiÅecki wrote: > ..... >> --- /dev/null >> +++ b/drivers/bcma/bcma_private.h > ..... >> + >> +#define BCMA_ADDR_BASE Â Â Â Â Â Â Â 0x18000000 >> +#define BCMA_WRAP_BASE Â Â Â Â Â Â Â 0x18100000 >> + > ...... >> --- /dev/null >> +++ b/drivers/bcma/scan.h >> @@ -0,0 +1,56 @@ >> +#ifndef BCMA_SCAN_H_ >> +#define BCMA_SCAN_H_ >> + >> +#define BCMA_ADDR_BASE Â Â Â Â Â Â Â 0x18000000 >> +#define BCMA_WRAP_BASE Â Â Â Â Â Â Â 0x18100000 >> + > ..... > > While graping through the code I found this. BCMA_ADDR_BASE and > BCMA_WRAP_BASE are defined twice. Will fix, thx. > Why are some constants defined in purpose specific headers in > drivers/bcma/*.h like drivers/bcma/scan.h and some in > drivers/bcma/bcma_private.h and other in include/linux/bcma/bcma_regs.h ? What is unclear to you in this split? It says everything. scan.h for scanning, regs for registers, private for internal functions. -- RafaÅ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
