Re: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/07/2011 08:48 PM, RafaÅ MiÅecki wrote:
2011/5/7 George Kashperko<george@xxxxxxxxxxx>:
I guess core id 0x800 by 0x04BF vendor and 0x800 by 0x043B vendor will
both be reported as ChipCommon which most likely is wrong for second
one. Btw, ChipCommon is 0x500 for 4706 and there will be more new core
codes for new Broadcom devices. Don't think its right to build core
names database into kernel while there will be at most few of them used
on particular end system.
This is constructive, I'll fix this, thanks.

Hi RafaÅ,

Late response, but I tried to tell what George clarified by the example above so you need nested switch.

I tend to agree with George that having this id to name conversion in the bus driver may be nice for debugging, but apart from memory usage it also gives you additional maintenance work. Leave it up to you.

Gr. AvS

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux