On 05/03/2011 09:00 AM, sukeshs@xxxxxxxxxxxx wrote:
From: Sukesh Srikakula<sukeshs@xxxxxxxxxxxxxxxxxxxxxxxxx>
Currently, there are 2 callbacks registered with OS for getting notifications when system goes to suspend/resume.
Racing between these 2 callbacks leads to failure in the suspend/resume path.
With this fix, we avoid registering dhd callback for suspend/resume notification when cfg80211 is used. Relevant functionality in dhd suspend/resume callback function is moved to cfg80211 suspend/resume functions.
Signed-off-by: Sukesh Srikakula<sukeshs@xxxxxxxxxxxx>
Signed-off-by: Sukesh Srikakula<sukeshs@xxxxxxxxxxxxxxxxxxxxxxxxx>
---
diff --git a/drivers/staging/brcm80211/brcmfmac/dhd.h b/drivers/staging/brcm80211/brcmfmac/dhd.h
index 99c38dd..41c55a6 100644
--- a/drivers/staging/brcm80211/brcmfmac/dhd.h
+++ b/drivers/staging/brcm80211/brcmfmac/dhd.h
@@ -123,6 +124,8 @@ typedef struct dhd_pub {
#if defined(CONFIG_PM_SLEEP)
+extern volatile bool dhd_mmc_suspend;
+
You probably should run checkpatch.pl on this patch. The volatile
keyword triggers a warning here. I grepped the fullmac code and this
variable is only set so what is its purpose (debugging?)? See
Documentation/volatile-considered-harmful.txt on this topic.
Gr. AvS
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
