Re: [PATCH] staging: brcm80211: brcmfmac: Add and use dhd_dbg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-04-28 at 11:46 -0700, Joe Perches wrote:
> All uses of DHD_<TYPE> macros are for debugging only.
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

Oh phoo...  This patch fails to compile when !DHD_DEBUG.
It's missing a define #dhd_dbg for the #DHD_DEBUG case

>  drivers/staging/brcm80211/brcmfmac/dhd_dbg.h    |   54 +-
[]
> diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_dbg.h b/drivers/staging/brcm80211/brcmfmac/dhd_dbg.h
> index 0817f13..b4db8d1 100644
> --- a/drivers/staging/brcm80211/brcmfmac/dhd_dbg.h
> +++ b/drivers/staging/brcm80211/brcmfmac/dhd_dbg.h
> @@ -19,33 +19,19 @@
>  #if defined(DHD_DEBUG)
[] 
>  #else	/* (defined BCMDBG) || (defined DHD_DEBUG) */

#define dhd_dbg(level, fmt, ...)			\
	no_printk(fmt, ##__VA_ARGS__)


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux