tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 5e8cdb6f6ebe28976876ab04995a5d3779b85082 commit: e70f17ed997cb7ee6c34089f2cdc2a9edc886503 [87/153] staging: vc04_services: Drop vchiq_log_error() in favour of dev_err config: csky-randconfig-r081-20231218 (https://download.01.org/0day-ci/archive/20231219/202312190038.zuEX32PB-lkp@xxxxxxxxx/config) compiler: csky-linux-gcc (GCC) 13.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202312190038.zuEX32PB-lkp@xxxxxxxxx/ smatch warnings: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:686 vchiq_initialise() error: we previously assumed 'state' could be null (see line 681) vim +/state +686 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c abf2836a381a307 Stefan Wahren 2021-04-25 668 int vchiq_initialise(struct vchiq_instance **instance_out) 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 669 { 2d0a0291135fd2f Dominic Braun 2018-12-14 670 struct vchiq_state *state; 4ddf9a2555caf21 Jamal Shareef 2019-11-05 671 struct vchiq_instance *instance = NULL; abf2836a381a307 Stefan Wahren 2021-04-25 672 int i, ret; 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 673 3da8757576ef789 Amarjargal Gundjalam 2020-10-28 674 /* 3da8757576ef789 Amarjargal Gundjalam 2020-10-28 675 * VideoCore may not be ready due to boot up timing. 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 676 * It may never be ready if kernel and firmware are mismatched,so don't 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 677 * block forever. 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 678 */ 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 679 for (i = 0; i < VCHIQ_INIT_RETRIES; i++) { 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 680 state = vchiq_get_state(); 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 @681 if (state) We exit early if state is valid 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 682 break; 81244ba0f03691a Stefan Wahren 2018-03-31 683 usleep_range(500, 600); 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 684 } 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 685 if (i == VCHIQ_INIT_RETRIES) { e70f17ed997cb7e Umang Jain 2023-12-05 @686 dev_err(state->dev, "core: %s: Videocore not initialized\n", __func__); ^^^^^^^^^^ state is NULL at this point. abf2836a381a307 Stefan Wahren 2021-04-25 687 ret = -ENOTCONN; 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 688 goto failed; 5c5e6ef6287cbf3 Arnd Bergmann 2018-02-02 689 } else if (i > 0) { -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
