Re: [PATCH 6/8] staging/mei: Header file contain the Userland API, (IOCTL and its struct)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 28, 2011 at 09:29:05AM +0300, Weil, Oren jer wrote:
> 
> >From: Greg KH [mailto:gregkh@xxxxxxx]
> >On Wed, Apr 27, 2011 at 08:15:41AM -0700, Randy Dunlap wrote:
> >> Please update Documentation/ioctl/ioctl-number.txt.
> >
> >Not yet, this code might get that ioctl removed before it gets merged into 
> >the
> >main part of the kernel.
> >
> >Or at least I can hope :)
> 
> We discuss this IOCTL issue with Alan C. and David W. and I didn't see any 
> other solution for this.

Was this discussed in public?

> if someone has a good solution for that we are happy to hear it.

Did you rule out sysfs, configfs, netlink, etc.?

> the reason that we use IOCTL is that we need to "associate" (Connect)
> the current file description to a FW Client/Feature.  (opening a comm
> channel) .

As you didn't document this ioctl interface anywhere, saying exactly
what you are trying to do, it makes it a bit hard to review your
existing interface to determine that ioctls are the correct thing for
your device.

Care to document it, or at least describe it in the patches somewhere so
we know it and can properly review it?

> and in addition there is a security issue that we would like limit the access 
> to mei driver to system admins.
> 
> From what I read we can't get those requirements with Netlinks, right?
> If there other methods for achieving this ?

sysfs, configfs, your own filesystem, etc.  There are lots of options.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux