> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxx] > Sent: Tuesday, April 26, 2011 4:58 PM > To: KY Srinivasan > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; > virtualization@xxxxxxxxxxxxxx; Haiyang Zhang; Abhishek Kane (Mindtree Consulting > PVT LTD); Hank Janssen > Subject: Re: [PATCH 18/25] Staging: hv: Get rid of struct hv_bus > > On Tue, Apr 26, 2011 at 08:23:25PM +0000, KY Srinivasan wrote: > > > > > > > -----Original Message----- > > > From: Greg KH [mailto:gregkh@xxxxxxx] > > > Sent: Tuesday, April 26, 2011 3:41 PM > > > To: KY Srinivasan > > > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; > > > virtualization@xxxxxxxxxxxxxx; Haiyang Zhang; Abhishek Kane (Mindtree > Consulting > > > PVT LTD); Hank Janssen > > > Subject: Re: [PATCH 18/25] Staging: hv: Get rid of struct hv_bus > > > > > > On Tue, Apr 26, 2011 at 09:20:35AM -0700, K. Y. Srinivasan wrote: > > > > Now, get rid of struct hv_bus. We will no longer be embedding > > > > struct bus_type. > > > > > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > > > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > > > Signed-off-by: Abhishek Kane <v-abkane@xxxxxxxxxxxxx> > > > > Signed-off-by: Hank Janssen <hjanssen@xxxxxxxxxxxxx> > > > > --- > > > > drivers/staging/hv/vmbus_drv.c | 33 ++++++++++++++------------------- > > > > 1 files changed, 14 insertions(+), 19 deletions(-) > > > > > > > > > > > > - hv_bus.bus.name = driver_name; > > > > + hv_bus.name = driver_name; > > > > > > Why are you setting the name of the bus again? Shouldn't this line be > > > removed? > > > > You are absolutely right. Since this redundancy was in the existing > > code, should I send you a separate patch to fix this? > > A separate one after this series is fine. Done; I have sent the patch out. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
