Re: [PATCH 2/3] wfx: add antenna configuration files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 7, 2022 at 1:04 PM Ben Brown <ben@xxxxxxxxxxx> wrote:
>
> On 21/02/2022 16:37, Jerome Pouiller wrote:
> > From: Jérôme Pouiller <jerome.pouiller@xxxxxxxxxx>
> <snip>
> > diff --git a/WHENCE b/WHENCE
> > index 0a6cb15..96f67f7 100644
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -5845,8 +5845,18 @@ Driver: wfx - Silicon Labs Wi-Fi Transceiver
> >  File: wfx/wfm_wf200_C0.sec
> >  Version: 3.12.1
> >
> > +File: wfx/brd4001a.pds not listed in WHENCE
> > +File: wfx/brd8022a.pds not listed in WHENCE
> > +File: wfx/brd8023a.pds not listed in WHENCE
>
> This format does not appear to be correct. While this will seemingly
> pass the `check_whence.py` check, it will be completely ignored by
> `copy-firmware.sh`, as that takes the full line after 'File: ' (e.g.
> 'wfx/brd4001a.pds not listed in WHENCE', which of course does not exist).

Oh, indeed.

> I'm assuming the trailing ' not listed in WHENCE' needs to be removed
> from each of these lines. Otherwise these are likely not being picked up
> by distros (they are missing from Arch, for example). This may have been
> the intention, but that seems odd (and unclear if so).

I doubt that was the intention.  I'll correct WHENCE in a separate
commit.  Thank you for reporting the issue.

josh
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux