The memory allocation function devm_kcalloc() may return NULL pointer, so it is better to add a check for 'p->func[i]->pins' to avoid possible NULL pointer dereference. Signed-off-by: QintaoShen <unSimple1993@xxxxxxx> --- drivers/pinctrl/ralink/pinctrl-rt2880.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/ralink/pinctrl-rt2880.c b/drivers/pinctrl/ralink/pinctrl-rt2880.c index 96fc06d..308610e 100644 --- a/drivers/pinctrl/ralink/pinctrl-rt2880.c +++ b/drivers/pinctrl/ralink/pinctrl-rt2880.c @@ -266,6 +266,10 @@ static int rt2880_pinmux_pins(struct rt2880_priv *p) p->func[i]->pin_count, sizeof(int), GFP_KERNEL); + + if (!p->func[i]->pins) + continue; + for (j = 0; j < p->func[i]->pin_count; j++) p->func[i]->pins[j] = p->func[i]->pin_first + j; -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
