On Wed, Nov 24, 2021 at 4:44 AM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Tue, Nov 23, 2021 at 11:17:37AM -0800, Todd Kjos wrote: > > +static int binder_do_deferred_txn_copies(struct binder_alloc *alloc, > > + struct binder_buffer *buffer, > > + struct list_head *sgc_head, > > + struct list_head *pf_head) > > +{ > > + int ret = 0; > > + struct list_head *entry, *tmp; > > + struct binder_ptr_fixup *pf = > > + list_first_entry_or_null(pf_head, struct binder_ptr_fixup, > > + node); > > + > > + list_for_each_safe(entry, tmp, sgc_head) { > ^^^^^^^^^^^^^^^^^^^ > All the list_for_each() loops can be changed to list_for_each_entry(). > > > list_for_each_entry_safe(sgc, tmp, sgc_head, node) { Will change. Thanks for the suggestion. > > regards, > dan carpenter > > > > > + size_t bytes_copied = 0; > > + struct binder_sg_copy *sgc = > > + container_of(entry, struct binder_sg_copy, node); > > + > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@xxxxxxxxxxx. > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel