Reply: Re: [PATCH 3/3] drm/loongson: Add interrupt driver for LS7A

[李晨阳 <lichenyang@xxxxxxxxxxx>]

> -----Original Messages-----
&gt; From: "Dan Carpenter" <dan.carpenter@xxxxxxxxxx>
&gt; Sent Time: 2021-07-06 17:05:01 (Tuesday)
&gt; To: lichenyang <lichenyang@xxxxxxxxxxx>
&gt; Cc: devel@xxxxxxxxxxxxxxxxxxxxxx
&gt; Subject: Re: [PATCH 3/3] drm/loongson: Add interrupt driver for LS7A
&gt; 
&gt; On Tue, Jul 06, 2021 at 02:36:31PM +0800, lichenyang wrote:
&gt; &gt;  int loongson_crtc_init(struct loongson_device *ldev, int index)
&gt; &gt; diff --git a/drivers/gpu/drm/loongson/loongson_drv.c b/drivers/gpu/drm/loongson/loongson_drv.c
&gt; &gt; index 252be9e25aff..89450c8c9102 100644
&gt; &gt; --- a/drivers/gpu/drm/loongson/loongson_drv.c
&gt; &gt; +++ b/drivers/gpu/drm/loongson/loongson_drv.c
&gt; &gt; @@ -167,6 +167,10 @@ static int loongson_drm_load(struct drm_device *dev, unsigned long flags)
&gt; &gt;  	if (ret)
&gt; &gt;  		dev_err(dev-&gt;dev, "Fatal error during modeset init: %d\n", ret);
&gt; &gt;  
&gt; &gt; +	ret = loongson_irq_init(ldev);
&gt; &gt; +	if (ret)
&gt; &gt; +		dev_err(dev-&gt;dev, "Fatal error during irq init: %d\n", ret);
&gt; 
&gt; It feel like there should be proper cleanup and error handling on this
&gt; path instead of just printing an error and continuing.

Thank you very much for your advice.

&gt; 
&gt; &gt; +
&gt; &gt;  	drm_kms_helper_poll_init(dev);
&gt; &gt;  	drm_mode_config_reset(dev);
&gt; &gt;  
&gt; 
&gt; regards,
&gt; dan carpenter


------------------------------
Loongson LiChenyang</lichenyang@xxxxxxxxxxx></dan.carpenter@xxxxxxxxxx>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel