Hi Dan：
On 2021/5/18 15:52, Dan Carpenter wrote:
On Mon, May 17, 2021 at 11:00:06PM +0800, Tang Bin wrote:
@@ -730,11 +730,7 @@ static int ad7746_probe(struct i2c_client *client,
if (ret < 0)
return ret;
- ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev);
- if (ret)
- return ret;
-
- return 0;
+ return devm_iio_device_register(indio_dev->dev.parent, indio_dev);
}
This sort of thing is done deliberately as a style choice... I probably
wouldn't have written it that way myself, but there really isn't a
downside to leaving it as-is.
The unused "int ret = 0;" just introduces a static checker warning about
unused assignments and disables the static checker warning for
uninitialized variables so we want to remove that.
Got it, I will send this patch for you.
Thanks
Tang Bin
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
