On Fri, Apr 30, 2021 at 10:48:12PM +0530, Deepak R Varma wrote: > On Fri, Apr 30, 2021 at 08:12:41PM +0300, Sakari Ailus wrote: > > Hi Deepak, > > > > On Fri, Apr 30, 2021 at 10:34:37PM +0530, Deepak R Varma wrote: > > > On Fri, Apr 30, 2021 at 07:33:27PM +0300, Sakari Ailus wrote: > > > > Hi Deepak, > > > > > > > > If you're touching all these lines, I might do a little more. Please see > > > > the comments below. > > > > > > > Hello Sakari, > > > I can definitely include other changes, but then it will be many different > > > types of changes into a single patch. Will that be okay? > > > > > > I was planning to address one issue per patch as I think the volume of > > > change is going to be high. I mentioned that in the notes section of the patch > > > message. > > > > I think I'd split the patch into smaller chunks if the result becomes too > > big but I don't think it's necessary yet. > > > > Splitting different kinds of simple cleanups into several patches takes > > longer time to review when they're touching the same piece of code. As the > > chunks in these patches have virtually no dependencies to other chunks, > > it's fine to do several kinds of cleanups at once. > > Okay, sure. That sounds good to me. I will include other related > improvements in the same area and send split patch set accordingly. I will > include this patch in the patch set. Hello Sakari and all, I have sent in the changes as suggested in a patch set with 5 individual patches. I will wait for your review and feedback before I work on other files. Thank you, deepak. > > Thank you for the guidance. > deepak. > > > > > -- > > Kind regards, > > > > Sakari Ailus _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
