Re: [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote:
> Fixed alignment of multi-line comment.
> Added a * for each line of the comment.
> 
> Signed-off-by: Abhishek C <astro.abhishek02@xxxxxxxxx>
> ---
>  drivers/android/binder.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index c119736ca56a..700719c58147 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -4617,8 +4617,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>  	unsigned int size = _IOC_SIZE(cmd);
>  	void __user *ubuf = (void __user *)arg;
>  
> -	/*pr_info("binder_ioctl: %d:%d %x %lx\n",
> -			proc->pid, current->pid, cmd, arg);*/
> +	/* pr_info("binder_ioctl: %d:%d %x %lx\n",
> +	 * proc->pid, current->pid, cmd, arg);
> +	 */

This looks like left-over debugging code, and as-is, is formatted
properly.

Why not just delete it entirely?  If someone needs debugging code, they
can add it back in.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux