Re: [PATCH] rtsx_chip.c:Fix usleep_range is preferred over udelay

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 18, 2021 at 04:38:37PM +0530, Akshith A V wrote:
> changed udelay to usleep_range 

Trailing whitespace and odd line wrap :(

> because usleep_range is preferred over udelay by checkpatch.pl
> 
> Signed-off-by: Akshith A V <akshith6384@xxxxxxxxx>
> ---
>  drivers/staging/rts5208/rtsx_chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
> index ee9ddc4eb94d..41ee334a4e6c 100644
> --- a/drivers/staging/rts5208/rtsx_chip.c
> +++ b/drivers/staging/rts5208/rtsx_chip.c
> @@ -1804,7 +1804,7 @@ void rtsx_exit_ss(struct rtsx_chip *chip)
>  
>  	if (chip->power_down_in_ss) {
>  		rtsx_force_power_on(chip, SSC_PDCTL | OC_PDCTL);
> -		udelay(1000);
> +		usleep_range(1000, 1010);

Does this really do anything different?

Did you test this?

>  	}
>  
>  	if (RTSX_TST_DELINK(chip)) {
> -- 
> 2.25.1
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux