Re: [PATCH 01/33] staging: rtl8723bs: remove typedefs in HalBtcOutSrc.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 15, 2021 at 05:14:15PM +0300, Dan Carpenter wrote:
> On Fri, Mar 12, 2021 at 09:26:06AM +0100, Marco Cesati wrote:
> > diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> > index ef8c6a0f31ae..87dc63408133 100644
> > --- a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> > +++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
> > @@ -151,7 +151,7 @@ static u8 halbtc8723b1ant_BtRssiState(
> >  }
> >  
> >  static void halbtc8723b1ant_UpdateRaMask(
> > -	PBTC_COEXIST pBtCoexist, bool bForceExec, u32 disRateMask
> > +	struct BTC_COEXIST * pBtCoexist, bool bForceExec, u32 disRateMask
> 
> There is an extra space between the "* pBtCoexist" which checkpatch
> warned you about.  :/  It makes me sad that you did all this work
> without looking at the checkpatch output.
> 
> ERROR: "foo * bar" should be "foo *bar"
> #146: FILE: drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c:154:
> +       struct BTC_COEXIST * pBtCoexist, bool bForceExec, u32 disRateMask
> 
> regards,
> dan carpenter

You are right, it was a fault of mine. However, I am sending another
patchset that fixes all POINTER_LOCATION errors in staging/rtl8723bs.

Marco


---- 
Marco Cesati, PhD
Dept. of Civil Engineering and Computer Science Engineering
Univ. of Rome Tor Vergata
via del Politecnico 1, I-00133 Rome, Italy
Tel. +39 06 7259 7389
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux