On Sun, Feb 21, 2021 at 09:35:44PM +0530, Shreesh Adiga wrote: > The check for interface is duplicated in 3 places and has been refactored > into a function. > > Signed-off-by: Shreesh Adiga <16567adigashreesh@xxxxxxxxx> > --- > drivers/staging/octeon/ethernet.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c > index 5dea6e96ec90..af546ef41843 100644 > --- a/drivers/staging/octeon/ethernet.c > +++ b/drivers/staging/octeon/ethernet.c > @@ -228,6 +228,12 @@ static struct net_device_stats *cvm_oct_common_get_stats(struct net_device *dev) > return &dev->stats; > } > > +static int cvm_oct_validate_interface(int interface) Shouldn't this return a bool? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
