Hi Nikolay, On Mon, Feb 22, 2021 at 12:21:36AM +0300, Nikolay K. wrote: > Hi Laurent, > > Thank you for the review. > I think that if we drop the unneeded parentheses here, we need to drop > them everywhere in the file for consistency, even in places checkpatch.pl That's a good point. > doesn't warn about. It'll increase patch size without actual usefullness > gain, as for me. I am very (very) novice to the kernel, > but who wants slightly more readable one-line simple macros? Let's keep your patch as-is, we can drop the unneeded parentheses in a subsequent patch if desired. -- Regards, Laurent Pinchart _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel