Re: [PATCH] staging: wimax/i2400m: fix byte-order type issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Feb 20, 2021 at 06:22:31PM +0530, karthik alapati wrote:
> fix sparse type warning by converting le32 types to
> host byte-order types before comparison
> 
> Signed-off-by: karthik alapati <mail@xxxxxxxxxxx>
> ---
>  drivers/staging/wimax/i2400m/fw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
> index 92ea5c101..f09de1810 100644
> --- a/drivers/staging/wimax/i2400m/fw.c
> +++ b/drivers/staging/wimax/i2400m/fw.c
> @@ -511,7 +511,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode,
>  			opcode, i2400m_brh_get_response(ack));
>  		goto error_ack_failed;
>  	}
> -	if (ack_size < ack->data_size + sizeof(*ack)) {
> +	if (ack_size < le32_to_cpu(ack->data_size) + sizeof(*ack)) {
>  		dev_err(dev, "boot-mode cmd %d: SW BUG "
>  			"driver provided only %zu bytes for %zu bytes "
>  			"of data\n", opcode, ack_size,

You sent 3 patches that seem to do the same thing, yet are a bit
different?

Please make your patches a patch series and provide proper subject lines
to make them unique.  I have now dropped all of your submitted patches
from my review queue.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux