[driver-core:debugfs_remove_return_value 2/8] drivers/net/wireless/broadcom/b43/debugfs.c:661:28: error: void value not ignored as it ought to be

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_remove_return_value
head:   5187c2360ee1d023078e4302dad32fda1e895772
commit: 72f2bf74b31aae983fb200aa7e84a05943bf27fc [2/8] debugfs: remove return value of debugfs_create_bool()
config: x86_64-randconfig-c002-20210216 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?id=72f2bf74b31aae983fb200aa7e84a05943bf27fc
        git remote add driver-core https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
        git fetch --no-tags driver-core debugfs_remove_return_value
        git checkout 72f2bf74b31aae983fb200aa7e84a05943bf27fc
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/net/wireless/broadcom/b43/debugfs.c: In function 'b43_add_dynamic_debug':
>> drivers/net/wireless/broadcom/b43/debugfs.c:661:28: error: void value not ignored as it ought to be
     661 |  e->dyn_debug_dentries[id] =    \
         |                            ^
   drivers/net/wireless/broadcom/b43/debugfs.c:666:2: note: in expansion of macro 'add_dyn_dbg'
     666 |  add_dyn_dbg("debug_xmitpower", B43_DBG_XMITPOWER, false);
         |  ^~~~~~~~~~~
>> drivers/net/wireless/broadcom/b43/debugfs.c:661:28: error: void value not ignored as it ought to be
     661 |  e->dyn_debug_dentries[id] =    \
         |                            ^
   drivers/net/wireless/broadcom/b43/debugfs.c:667:2: note: in expansion of macro 'add_dyn_dbg'
     667 |  add_dyn_dbg("debug_dmaoverflow", B43_DBG_DMAOVERFLOW, false);
         |  ^~~~~~~~~~~
>> drivers/net/wireless/broadcom/b43/debugfs.c:661:28: error: void value not ignored as it ought to be
     661 |  e->dyn_debug_dentries[id] =    \
         |                            ^
   drivers/net/wireless/broadcom/b43/debugfs.c:668:2: note: in expansion of macro 'add_dyn_dbg'
     668 |  add_dyn_dbg("debug_dmaverbose", B43_DBG_DMAVERBOSE, false);
         |  ^~~~~~~~~~~
>> drivers/net/wireless/broadcom/b43/debugfs.c:661:28: error: void value not ignored as it ought to be
     661 |  e->dyn_debug_dentries[id] =    \
         |                            ^
   drivers/net/wireless/broadcom/b43/debugfs.c:669:2: note: in expansion of macro 'add_dyn_dbg'
     669 |  add_dyn_dbg("debug_pwork_fast", B43_DBG_PWORK_FAST, false);
         |  ^~~~~~~~~~~
>> drivers/net/wireless/broadcom/b43/debugfs.c:661:28: error: void value not ignored as it ought to be
     661 |  e->dyn_debug_dentries[id] =    \
         |                            ^
   drivers/net/wireless/broadcom/b43/debugfs.c:670:2: note: in expansion of macro 'add_dyn_dbg'
     670 |  add_dyn_dbg("debug_pwork_stop", B43_DBG_PWORK_STOP, false);
         |  ^~~~~~~~~~~
>> drivers/net/wireless/broadcom/b43/debugfs.c:661:28: error: void value not ignored as it ought to be
     661 |  e->dyn_debug_dentries[id] =    \
         |                            ^
   drivers/net/wireless/broadcom/b43/debugfs.c:671:2: note: in expansion of macro 'add_dyn_dbg'
     671 |  add_dyn_dbg("debug_lo", B43_DBG_LO, false);
         |  ^~~~~~~~~~~
>> drivers/net/wireless/broadcom/b43/debugfs.c:661:28: error: void value not ignored as it ought to be
     661 |  e->dyn_debug_dentries[id] =    \
         |                            ^
   drivers/net/wireless/broadcom/b43/debugfs.c:672:2: note: in expansion of macro 'add_dyn_dbg'
     672 |  add_dyn_dbg("debug_firmware", B43_DBG_FIRMWARE, false);
         |  ^~~~~~~~~~~
>> drivers/net/wireless/broadcom/b43/debugfs.c:661:28: error: void value not ignored as it ought to be
     661 |  e->dyn_debug_dentries[id] =    \
         |                            ^
   drivers/net/wireless/broadcom/b43/debugfs.c:673:2: note: in expansion of macro 'add_dyn_dbg'
     673 |  add_dyn_dbg("debug_keys", B43_DBG_KEYS, false);
         |  ^~~~~~~~~~~
>> drivers/net/wireless/broadcom/b43/debugfs.c:661:28: error: void value not ignored as it ought to be
     661 |  e->dyn_debug_dentries[id] =    \
         |                            ^
   drivers/net/wireless/broadcom/b43/debugfs.c:674:2: note: in expansion of macro 'add_dyn_dbg'
     674 |  add_dyn_dbg("debug_verbose_stats", B43_DBG_VERBOSESTATS, false);
         |  ^~~~~~~~~~~


vim +661 drivers/net/wireless/broadcom/b43/debugfs.c

e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  654  
e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  655  static void b43_add_dynamic_debug(struct b43_wldev *dev)
e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  656  {
e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  657  	struct b43_dfsentry *e = dev->dfsentry;
e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  658  
e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  659  #define add_dyn_dbg(name, id, initstate) do {			\
e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  660  	e->dyn_debug[id] = (initstate);				\
e9bdcdc7cdf028 drivers/net/wireless/broadcom/b43/debugfs.c Greg Kroah-Hartman 2019-01-22 @661  	e->dyn_debug_dentries[id] =				\
e9bdcdc7cdf028 drivers/net/wireless/broadcom/b43/debugfs.c Greg Kroah-Hartman 2019-01-22  662  		debugfs_create_bool(name, 0600, e->subdir,	\
e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  663  				&(e->dyn_debug[id]));		\
e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  664  	} while (0)
e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  665  
621a5f7ad9cd1c drivers/net/wireless/b43/debugfs.c          Viresh Kumar       2015-09-26  666  	add_dyn_dbg("debug_xmitpower", B43_DBG_XMITPOWER, false);
621a5f7ad9cd1c drivers/net/wireless/b43/debugfs.c          Viresh Kumar       2015-09-26  667  	add_dyn_dbg("debug_dmaoverflow", B43_DBG_DMAOVERFLOW, false);
621a5f7ad9cd1c drivers/net/wireless/b43/debugfs.c          Viresh Kumar       2015-09-26  668  	add_dyn_dbg("debug_dmaverbose", B43_DBG_DMAVERBOSE, false);
621a5f7ad9cd1c drivers/net/wireless/b43/debugfs.c          Viresh Kumar       2015-09-26  669  	add_dyn_dbg("debug_pwork_fast", B43_DBG_PWORK_FAST, false);
621a5f7ad9cd1c drivers/net/wireless/b43/debugfs.c          Viresh Kumar       2015-09-26  670  	add_dyn_dbg("debug_pwork_stop", B43_DBG_PWORK_STOP, false);
621a5f7ad9cd1c drivers/net/wireless/b43/debugfs.c          Viresh Kumar       2015-09-26  671  	add_dyn_dbg("debug_lo", B43_DBG_LO, false);
621a5f7ad9cd1c drivers/net/wireless/b43/debugfs.c          Viresh Kumar       2015-09-26  672  	add_dyn_dbg("debug_firmware", B43_DBG_FIRMWARE, false);
621a5f7ad9cd1c drivers/net/wireless/b43/debugfs.c          Viresh Kumar       2015-09-26  673  	add_dyn_dbg("debug_keys", B43_DBG_KEYS, false);
621a5f7ad9cd1c drivers/net/wireless/b43/debugfs.c          Viresh Kumar       2015-09-26  674  	add_dyn_dbg("debug_verbose_stats", B43_DBG_VERBOSESTATS, false);
e4d6b7951812d9 drivers/net/wireless/b43/debugfs.c          Michael Buesch     2007-09-18  675  

:::::: The code at line 661 was first introduced by commit
:::::: e9bdcdc7cdf02819ea3f4205c7286ab97a9e1a1b b43: no need to check return value of debugfs_create functions

:::::: TO: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
:::::: CC: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux