On Sat, Apr 16, 2011 at 01:33, Greg KH <greg@xxxxxxxxx> wrote: > On Sat, Apr 16, 2011 at 12:50:51AM +0300, Zeev Tarantov wrote: >> From: Zeev Tarantov <zeev.tarantov@xxxxxxxxx> >> >> Zram currently uses LZO compression. With Snappy, it uses less CPU time and is >> thus more useful. The sacrifice in compression ratio is small. >> Zram's LZO and Snappy support can be independently enabled at compile time and >> each zram device can switch between compression methods when unused. >> When only a single compression method was enabled at compile time, no idirection >> penalty is incurred. > > Ick, why have the ability to switch at all, that just adds lots of code > complexity and mess. > > Please just switch to the new mode if it's always faster and better. > That should make your patch easier to read and understand. Because I could not test on other hardware than x86-64, I can not in good conscience recommend just switching from LZO to Snappy. I will send a version of patch 2 with only compile-time switching. It is indeed shorter. > thanks, > > greg k-h Thank you, -Z.T. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
