On Tue, Feb 16, 2021 at 12:28:01PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 16, 2021 at 07:13:53PM +0800, Du Cheng wrote:
> > fix macro gb_loopback_stats_attrs by wrapping its multi-line definition
> > inside a do {} while(0) block, in compliance to scripts/checkpatch.pl.
> >
> > Signed-off-by: Du Cheng <ducheng2@xxxxxxxxx>
> > ---
> > changes v2:
> > * relign backslashes with tabstop=8
> > * improve description and subject
> >
> > changes v1:
> > * fix coding style of the macro
> >
> > drivers/staging/greybus/loopback.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> > index 2471448ba42a..24b769688817 100644
> > --- a/drivers/staging/greybus/loopback.c
> > +++ b/drivers/staging/greybus/loopback.c
> > @@ -163,9 +163,11 @@ static ssize_t name##_avg_show(struct device *dev, \
> > static DEVICE_ATTR_RO(name##_avg)
> >
> > #define gb_loopback_stats_attrs(field) \
> > +do { \
> > gb_loopback_ro_stats_attr(field, min, u); \
> > gb_loopback_ro_stats_attr(field, max, u); \
> > - gb_loopback_ro_avg_attr(field)
> > + gb_loopback_ro_avg_attr(field); \
> > +} while (0)
> >
> > #define gb_loopback_attr(field, type) \
> > static ssize_t field##_show(struct device *dev, \
> > --
> > 2.27.0
>
> Did you successfully build this change?
>
> Please do so...
>
> thanks,
>
> greg k-h
I realized I did not enable greybus subsystem in the config.
after the enabling CONFIG_GREYBUS_LOOPBACK=m the make failed with compilation errors.
Then I realized this macro is actually used for function definition, not as statements.
I shall take back this PATCH as the proposed change in not applicable in this case.
Thanks!
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
