On Tue, Feb 16, 2021 at 04:53:26PM +0800, Du Cheng wrote: > align * in block comments on each line > > changes v3: > - add SUBSYSTEM in subject line > - add explanation to past version of this patch > > changes v2: > - move closing of comment to the same line > > changes v1: > - align * in block comments These "changes" should all go below the --- line, right? And the subject shoudl be a bit more specific, look at how other commits are done for this driver. Something like: Subject: staging: qlge: fix comment style in qlge_main.c matches much better, and conveys what is actually happening here, right? v4 please? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel