On Tue, Feb 2, 2021 at 3:52 AM Carlis <zhangxuezhi3@xxxxxxxxx> wrote: > On Mon, 1 Feb 2021 19:40:21 +0200 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > On Sat, Jan 30, 2021 at 8:39 AM carlis <zhangxuezhi3@xxxxxxxxx> wrote: > > > On Fri, 29 Jan 2021 16:26:12 +0200 > > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > > On Fri, Jan 29, 2021 at 3:56 PM carlis <zhangxuezhi3@xxxxxxxxx> > > > > wrote: > > > > > On Fri, 29 Jan 2021 12:23:08 +0200 > > > > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > > > ... > > > > > > > Hi, I apologize for what I said in the previous two emails. I > > > > > missed one email you sent before, and now I probably understand > > > > > what you meant. Here is a version I modified according to your > > > > > suggestion: > > > > I have realized that you are mocking stuff in the generic fbtft > > structure for all drivers while only a single one is going to use > > that. Consider moving everything to the driver in question. > Do you mean that i define the TE completion and irq_te in the > fb_st7789v.c as i did before? Not in global variables. Perhaps it will require to add/update the custom (to the specific driver) data structure. But the idea is that all changes should be isolated to that driver. -- With Best Regards, Andy Shevchenko _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
