Re: [PATCH] staging: wfx: logical continuations should be on the previous line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 14, 2021 at 05:16:41AM +0800, zhuo1angt@xxxxxxxxxxx wrote:
> Move logical or operator to previous line to comply with
> the standard kernel coding style.
> 
> Signed-off-by: Zhuoran He <zhuo1angt@xxxxxxxxxxx>
> ---
> drivers/staging/wfx/hif_rx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c
> index 56a5f8914..9fca7f263 100644
> --- a/drivers/staging/wfx/hif_rx.c
> +++ b/drivers/staging/wfx/hif_rx.c
> @@ -391,9 +391,9 @@ void wfx_handle_rx(struct wfx_dev *wdev, struct sk_buff
> *skb)
>  }
>  // Note: mutex_is_lock cause an implicit memory barrier that protect
>  // buf_send
> - if (mutex_is_locked(&wdev->hif_cmd.lock)
> - && wdev->hif_cmd.buf_send
> - && wdev->hif_cmd.buf_send->id == hif_id) {
> + if (mutex_is_locked(&wdev->hif_cmd.lock) &&
> + wdev->hif_cmd.buf_send &&
> + wdev->hif_cmd.buf_send->id == hif_id) {
>   hif_generic_confirm(wdev, hif, hif->body);
>   goto free;
>  }
> --
> 2.30.1

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux