On Fri, Feb 12, 2021 at 02:39:26PM +0530, Viresh Kumar wrote:
> On 12-02-21, 13:48, Pritthijit Nath wrote:
> > This change fixes a checkpatch CHECK style issue for "Alignment should match
> > open parenthesis".
> >
> > Signed-off-by: Pritthijit Nath <pritthijit.nath@xxxxxxxxxx>
> > ---
> > drivers/staging/greybus/hid.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/greybus/hid.c b/drivers/staging/greybus/hid.c
> > index ed706f39e87a..a56c3fb5d35a 100644
> > --- a/drivers/staging/greybus/hid.c
> > +++ b/drivers/staging/greybus/hid.c
> > @@ -221,8 +221,8 @@ static void gb_hid_init_reports(struct gb_hid *ghid)
> > }
> >
> > static int __gb_hid_get_raw_report(struct hid_device *hid,
> > - unsigned char report_number, __u8 *buf, size_t count,
> > - unsigned char report_type)
> > + unsigned char report_number, __u8 *buf, size_t count,
> > + unsigned char report_type)
> > {
> > struct gb_hid *ghid = hid->driver_data;
> > int ret;
>
> I can't even count the number of attempts we have seen in previous
> years to make checkpatch --strict happy for greybus.
>
> I say we make this change once and for all across greybus, so we don't
> have to review or NAK someone afterwards.
>
> Should I send a patch for this ?
Sure, but note that over time, checkpatch adds new things so there will
always be something to change in here, until we move it out of the
drivers/staging/ area :)
I need to go fix up the greybus vibrator patch which was my first
attempt at getting back into that effort...
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
