Hi, On Fri, Feb 12, 2021 at 8:59 AM shivang upadhyay <oroz3x@xxxxxxxxx> wrote: > > Signed-off-by: shivang upadhyay <oroz3x@xxxxxxxxx> There's no description here. Even though this seems like a trivial patch, it should still be there. Your commit message would look something like ks7010: enclose non-trivial defines in parentheses Checkpatch complains that parentheses are missing: <quote the checkpatch warning or something> Fix that. Also, if you're sending new versions of your patch, make sure to include the patch version in your subject: [PATCH v3] ks7010: enclose non-trivial defines in parentheses You can use the '--reroll-count=N' option from git-format-patch to automate that. Good luck on your next roll, Frans _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel