Re: [PATCH] Staging: vt6655: Replace a camel case variable name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/02/10 06:50PM, Greg Kroah-Hartman wrote:
> On Wed, Feb 10, 2021 at 06:42:07PM +0800, Yujia Qiao wrote:
> > Replace camel case variable names with snake case in baseband.c.
> >
> > Signed-off-by: Yujia Qiao <rapiz@xxxxxxxxxxx>
> > ---
> >  drivers/staging/vt6655/baseband.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> This doesn't apply cleanly to my staging-next branch, can you please
> rebase it and resend?
>
> thanks,
>
> greg k-h
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

When I first encountered the CamelCase check I believed that
making such changes would only cause trouble for others.

Are such changes to API welcome in the kernel?
I presume it is as long it doesn't break building the kernel

If I do decide to fix such checks what must I look out for?

thanks,
aakash hemadri
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux