Hi Dan, On Mon, Feb 08, 2021 at 04:45:17PM +0300, Dan Carpenter wrote: > On Sun, Feb 07, 2021 at 05:23:28PM +0800, Youling Tang wrote: > > Fix the below ignoring return value warning for device_reset. > > > > drivers/staging/mt7621-dma/mtk-hsdma.c:685:2: warning: ignoring return value > > of function declared with 'warn_unused_result' attribute [-Wunused-result] > > device_reset(&pdev->dev); > > ^~~~~~~~~~~~ ~~~~~~~~~~ > > drivers/staging/ralink-gdma/ralink-gdma.c:836:2: warning: ignoring return value > > of function declared with 'warn_unused_result' attribute [-Wunused-result] > > device_reset(&pdev->dev); > > ^~~~~~~~~~~~ ~~~~~~~~~~ > > > > We can't really do this sort of fix without the hardware to test it. > This could be the correct fix or perhaps switching to device_reset_optional() > is the correct fix. We can't know unless we have the hardware to test. When device_reset() is the wrong function then adding a return value check will turn this into a runtime error for those who have the hardware which will hopefully trigger them to tell us why reset_device is wrong for them. At least for a staging driver I find this procedure opportune. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
