On 21/02/04 03:58PM, Nathan Chancellor wrote: > On Fri, Feb 05, 2021 at 03:24:51AM +0530, ameynarkhede02@xxxxxxxxx wrote: > > From: Amey Narkhede <ameynarkhede02@xxxxxxxxx> > > > > Use min_t instead of min function in qlge/qlge_main.c > > Fixes following checkpatch.pl warning: > > WARNING: min() should probably be min_t(int, MAX_CPUS, num_online_cpus()) > > > > Signed-off-by: Amey Narkhede <ameynarkhede02@xxxxxxxxx> > > --- > > drivers/staging/qlge/qlge_main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c > > index 402edaeff..29606d1eb 100644 > > --- a/drivers/staging/qlge/qlge_main.c > > +++ b/drivers/staging/qlge/qlge_main.c > > @@ -3938,7 +3938,7 @@ static int ql_configure_rings(struct ql_adapter *qdev) > > int i; > > struct rx_ring *rx_ring; > > struct tx_ring *tx_ring; > > - int cpu_cnt = min(MAX_CPUS, (int)num_online_cpus()); > > + int cpu_cnt = min_t(int, MAX_CPUS, (int)num_online_cpus()); > > You should remove the cast on num_online_cpus() like checkpatch > suggests. min_t adds the cast to int on both of the inputs for you. > Thanks. Fixed in v2 Amey
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
