Re: [PATCH RFC] staging: comedi: fix coding style issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 04, 2021 at 05:43:37PM +0530, Ayush wrote:
> fix IF_0 and IF_1 warnings by checkpatch.pl

What is that?

> Signed-off-by: Ayush <ayush@xxxxxxxxxxx>
> ---
> compile tested only.

When you send something with "RFC" that means you do not think it is
good enough to be merged, and so I will just delete it.  Also, you did
not ask a question that you want to be answered, so why is this RFC?

> 
>  drivers/staging/comedi/drivers/dt2801.c | 29 -------------------------
>  1 file changed, 29 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/dt2801.c b/drivers/staging/comedi/drivers/dt2801.c
> index 0d571d817b4e..bb01416084e4 100644
> --- a/drivers/staging/comedi/drivers/dt2801.c
> +++ b/drivers/staging/comedi/drivers/dt2801.c
> @@ -87,17 +87,6 @@
>  #define DT2801_STATUS		1
>  #define DT2801_CMD		1
>  
> -#if 0
> -/* ignore 'defined but not used' warning */
> -static const struct comedi_lrange range_dt2801_ai_pgh_bipolar = {
> -	4, {
> -		BIP_RANGE(10),
> -		BIP_RANGE(5),
> -		BIP_RANGE(2.5),
> -		BIP_RANGE(1.25)
> -	}
> -};
> -#endif

Please leave these alone, it's good documentation.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux