Em Fri, 29 Jan 2021 16:45:11 +0100 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> escreveu: > On Fri, Jan 29, 2021 at 04:03:36PM +0100, Mauro Carvalho Chehab wrote: > > Instead of doing its own SPMI I/O implementation, use the > > already-existing regmap one. > > > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> > > --- > > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 115 ++++++------------ > > .../staging/hikey9xx/hi6421v600-regulator.c | 26 ++-- > > include/linux/mfd/hi6421-spmi-pmic.h | 7 +- > > 3 files changed, 52 insertions(+), 96 deletions(-) > > After applying this, I get a build failure: > > ERROR: modpost: "__devm_regmap_init_spmi_ext" [drivers/staging/hikey9xx/hi6421-spmi-pmic.ko] undefined! > > So you need some sort of build dependancy here :( It seems that it is missing REGMAP_SPMI. > Also, when I apply the first 9 patches and stop, I get a build error > that you should see as well, so I can't take any of these right now, > sorry. Gah, there was a rename patch which a hunk that went into the following patch. Sorry. Added the missing select REGMAP_SPMI / REGMAP, fixed it and tested, patch-per-patch. I'll run a new test at the hardware to double-check if everything is OK at the hardware and should be re-submitting the series soon enough. Thanks, Mauro _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
