On Fri, Jan 29, 2021 at 2:54 PM carlis <zhangxuezhi3@xxxxxxxxx> wrote: > On Fri, 29 Jan 2021 12:23:08 +0200 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Fri, Jan 29, 2021 at 7:01 AM carlis <zhangxuezhi3@xxxxxxxxx> wrote: > > > On Thu, 28 Jan 2021 16:33:02 +0200 > > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: ... > > This one is not like I suggested. > I don't think I have a problem here, if te GPIO is not configured, it > should return NULL, if it is configured, it should be greater than 0 Pointers are always greater than 0 or a special NULL case. The rationale I explained in the previous mail. ... > > > rc = devm_request_irq(dev, > > > par->irq_te, > > > panel_te_handler, > > > IRQF_TRIGGER_RISING, > > > "TE_GPIO", par); > > > > Try to use less LOCs. > > LOCs???? i can not get you Lines Of Code. Above can occupy less LOCs. -- With Best Regards, Andy Shevchenko _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
