Re: [PATCH 16/17] rtl8192e: Rewrite macro as inline function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2011-04-13 at 09:21 +0900, Mike McCormack wrote:
> diff --git a/drivers/staging/rtl8192e/r8192E.h b/drivers/staging/rtl8192e/r8192E.h
> index 30a0b8a..9ec1fc4 100644
> --- a/drivers/staging/rtl8192e/r8192E.h
> +++ b/drivers/staging/rtl8192e/r8192E.h

> +static inline u8 rtl8192e_get_sifs_time(struct r8192_priv *priv)

I don't think this should be either inline or u8.

> +{
> +	switch (priv->ieee80211->current_network.mode)
> +	{

Normal kernel style is for switch is

	switch (foo) {


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux