Hi Vinod, This series contain just the PHY patch I sent in Nov, 30 from this series: Move Hikey 970 USB support out of staging and add DT The 3 initial patches address the issues you pointed during your review: patch 1 change the logic to use GENMASK and FIELD_GET/FIELD_PREP macros. It also places all hexadecimal values in lowercase; patch 2 add a delay inside the retry logic; patch 3 changes a function to return a boolean. The 4th patch is actually identical to the patch I sent previously: it just moves the driver to drivers/phy: rename {drivers/staging/hikey9xx => Documentation/devicetree/bindings/phy}/phy-hi3670-usb3.yaml (100%) rename drivers/{staging/hikey9xx => phy/hisilicon}/phy-hi3670-usb3.c (100%) Yet, in order to make this series easier to review, I'm submitting it with --no-merges. This way, you can check the driver as a hole while reviewing the last patch. Mauro Carvalho Chehab (4): staging: hikey9xx: phy-hi3670-usb3.c: use bitfield macros staging: hikey9xx: phy-hi3670-usb3.c: adjust retry logic staging: hikey9xx: phy-hi3670-usb3.c: hi3670_is_abbclk_seleted() returns bool phy: phy-hi3670-usb3: move driver from staging into phy .../bindings/phy/phy-hi3670-usb3.yaml | 72 ++ MAINTAINERS | 9 +- drivers/phy/hisilicon/Kconfig | 10 + drivers/phy/hisilicon/Makefile | 1 + drivers/phy/hisilicon/phy-hi3670-usb3.c | 668 +++++++++++++++++ drivers/staging/hikey9xx/Kconfig | 11 - drivers/staging/hikey9xx/Makefile | 2 - drivers/staging/hikey9xx/phy-hi3670-usb3.c | 671 ------------------ drivers/staging/hikey9xx/phy-hi3670-usb3.yaml | 72 -- 9 files changed, 759 insertions(+), 757 deletions(-) create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3670-usb3.yaml create mode 100644 drivers/phy/hisilicon/phy-hi3670-usb3.c delete mode 100644 drivers/staging/hikey9xx/phy-hi3670-usb3.c delete mode 100644 drivers/staging/hikey9xx/phy-hi3670-usb3.yaml -- 2.29.2 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel