Re: [PATCH v2 0/3] A trio of vchiq bulk transfer fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2021-01-05 at 16:20 +0000, Phil Elwell wrote:
> The recent batch of vchiq improvements broke bulk transfers in two ways:
> 
> 1. The userdata associated with a transfer was lost in the case that a
>    non-blocking mode was used.
> 
> 2. The 64-bit ioctl compatibility shim for a bulk transfer used the
>    wrong ioctl command.
> 
> This patch set fixes both of those bugs, and adds a security-related
> note to the TODO file.
> 
> Changes in v2:
> - Expand the commit message on patch 1 to clarify the impact of the
>   bug, and add Tested-by.
> - Add commit 3 with an additional TODO item.
> - Change the name of the patch set to be numerically accurate.
> 
> Phil Elwell (3):
>   staging: vchiq: Fix bulk userdata handling
>   staging: vchiq: Fix bulk transfers on 64-bit builds
>   staging: vc04_services: Add a note to the TODO
> 
>  drivers/staging/vc04_services/interface/TODO                | 4 ++++
>  .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c   | 6 ++++--
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx>

Regards,
Nicolas

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux