On Wed, Jan 06, 2021 at 01:17:47PM -0800, Joe Perches wrote: > On Wed, 2021-01-06 at 22:36 +0300, Dan Carpenter wrote: > > On Wed, Jan 06, 2021 at 10:25:26AM -0800, Joe Perches wrote: > > > On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote: > > > > On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote: > > > > > On 06-Jan-21 09:51, Greg Kroah-Hartman wrote: > > > > > > On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip Kolev wrote: > > > > > > > There is a debug message using hardcoded function name instead of the > > > > > > > __func__ macro. Replace it. > > > > > > > > > > > > > > Report from checkpatch.pl on the file: > > > > > > > > > > > > > > WARNING: Prefer using '"%s...", __func__' to using 'ov2722_remove', this function's name, in a string > > > > > > > + dev_dbg(&client->dev, "ov2722_remove...\n"); > [] > > > There are quite a lot of these relatively useless function tracing like > > > uses in the kernel: > > > > > > $ git grep -P '"%s[\.\!]*\\n"\s*,\s*__func__\s*\)' | wc -l > > > 1065 > > > > These are printing other stuff besides just the function name. > > No, these are printing _only_ the function name. > Oh... Duh... I was looking at the complete wrong output. My bad. Yeah. I like this warning. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
