Hi Yongjun, many thanks for your patch. On Wed, Dec 30, 2020 at 09:37:06AM +0800, Zheng Yongjun wrote: > Use kzalloc rather than kcalloc(1,...) > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > @@ > > - kcalloc(1, > + kzalloc( > ...) > // </smpl> > > Signed-off-by: Zheng Yongjun <zhengyongjun3@xxxxxxxxxx> Like Alex said, LGTM also. Reviewed-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx> ------ Cheers, Rui > --- > drivers/staging/greybus/light.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c > index d2672b65c3f4..87d36948c610 100644 > --- a/drivers/staging/greybus/light.c > +++ b/drivers/staging/greybus/light.c > @@ -290,8 +290,7 @@ static int channel_attr_groups_set(struct gb_channel *channel, > channel->attrs = kcalloc(size + 1, sizeof(*channel->attrs), GFP_KERNEL); > if (!channel->attrs) > return -ENOMEM; > - channel->attr_group = kcalloc(1, sizeof(*channel->attr_group), > - GFP_KERNEL); > + channel->attr_group = kzalloc(sizeof(*channel->attr_group), GFP_KERNEL); > if (!channel->attr_group) > return -ENOMEM; > channel->attr_groups = kcalloc(2, sizeof(*channel->attr_groups), > -- > 2.22.0 > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
