Re: [PATCH v3 12/24] wfx: add hif_api_*.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 22 December 2020 16:20:46 CET Kalle Valo wrote:
> Jerome Pouiller <Jerome.Pouiller@xxxxxxxxxx> writes:
> 
> > --- /dev/null
> > +++ b/drivers/net/wireless/silabs/wfx/hif_api_general.h
> > @@ -0,0 +1,267 @@
> > +/* SPDX-License-Identifier: Apache-2.0 */
> > +/*
> > + * WFx hardware interface definitions
> > + *
> > + * Copyright (c) 2018-2020, Silicon Laboratories Inc.
> > + */
> > +
> > +#ifndef WFX_HIF_API_GENERAL_H
> > +#define WFX_HIF_API_GENERAL_H
> > +
> > +#ifdef __KERNEL__
> > +#include <linux/types.h>
> > +#include <linux/if_ether.h>
> > +#else
> > +#include <net/ethernet.h>
> > +#include <stdint.h>
> > +#define __packed __attribute__((__packed__))
> > +#endif
> 
> Why check for __KERNEL__ and redefined __packed? These don't belong to a
> wireless driver.

In the old days, this file was shared with other projects. I though I had
cleaned all these things.

-- 
Jérôme Pouiller


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux