2011/4/12 Greg KH <greg@xxxxxxxxx>: > On Tue, Apr 12, 2011 at 07:41:18AM +0200, RafaÅ MiÅecki wrote: >> > You can't do that, no static struct devices please. ÂMake these dynamic >> > and everything will be fine. ÂThe -mm tree used to have a huge warning >> > if you ever tried to register a statically allocated struct, but that >> > didn't really work out, but would have saved you a lot of time here, >> > sorry. >> > >> > So dynamically allocate the structures and you will be fine. >> >> Well, I saw that along kernel, I had no idea there is anything wrong >> about this. It seems more ppl do not know about this: >> struct radeon_ib   Âibs[RADEON_IB_POOL_SIZE]; >> struct radeon_pm_clock_info clock_info[8]; >> struct radeon_pm_profile profiles[PM_PROFILE_MAX]; >> struct radeon_surface_reg surface_regs[RADEON_GEM_MAX_SURFACES]; > > Are you sure these are all containing a 'struct device'? I didn't catch from you mail that you mean "struct device" only. I though it apply to all structs. >> checkpatch does no catch this, so maybe just some manual? Could you >> point me to it? > > It's a structure that has dynamic lifetime rules, you can't statically > allocate it safely. ÂIt's that simple. Ah, and this is a great explanation, for all the time I tough the problem is memory issue. Now it makes sense, thanks. -- RafaÅ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
