Re: [PATCH 01/12] media: atomsip: Convert comments to C99 initializers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 07, 2020 at 08:26:27PM +0100, Philipp Gerlesberger wrote:
> The struct initalizers have been changed as recommended on
> https://kernelnewbies.org/KernelJanitors/Todo
> 
> Co-developed-by: Andrey Khlopkov <ij72uhux@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Andrey Khlopkov <ij72uhux@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@xxxxxx>
> ---
>  .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c  | 30 +++++++++----------
>  1 file changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> index b4f53be18e7f..af61d05e88d3 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
> @@ -31,33 +31,33 @@ static struct ia_css_rmgr_vbuf_handle handle_table[NUM_HANDLES];
>   * @brief VBUF resource pool - refpool
>   */
>  static struct ia_css_rmgr_vbuf_pool refpool = {
> -	false,			/* copy_on_write */
> -	false,			/* recycle */
> -	0,			/* size */
> -	0,			/* index */
> -	NULL,			/* handles */
> +	.copy_on_write	= false,
> +	.recycle	= false,
> +	.size		= 0,
> +	.index		= 0,
> +	.handles	= NULL,

If you're using C99 initializers then you can remove all the false, 0
and NULL members.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux