Re: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2011/4/8 Joe Perches <joe@xxxxxxxxxxx>:
> On Fri, 2011-04-08 at 21:45 +0200, RafaÅ MiÅecki wrote:
>> diff --git a/include/linux/axi/axi.h b/include/linux/axi/axi.h
> []
>> +#define axi_info   pr_info
>> +#ifdef CONFIG_AXI_DEBUG
>> +#define axi_debug  Âpr_debug
>> +#else
>> +#define axi_debug  Âdo { } while (0)
>> +#endif
>> +#define axi_err       Âpr_err
>
> I think redefining standard functionality like
> this doesn't gain anything and loses some basic
> grep capability.

But on the other hand using:
pr_info, pr_err, BUT axi_debug
can easily lead to mistakes.

Or is this possible to re-define pr_debug locally?

-- 
RafaÅ
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux